Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3745 - Modify process that reads SIN & CRA verification response files #3835

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

bidyashish
Copy link
Collaborator

@bidyashish bidyashish commented Oct 24, 2024

Acceptance Criteria

  • Jobs must continue processing remaining records in a file after it fails to process a record.
  • SIN and CRA response files will need to be archived after processing even where there are failed records. (IMB staff will need to monitor the jobs to confirm if errors occur processing SIMS response files and address them accordingly)
  • Disable error reporting when SIMS Reference_IDX fails to match.
  • If records are identified as SIMS records (based on the project area information being present), errors will be generated as usual.
    • If records are identified as SFAS records (based on the project area information NOT being present), records should be skipped.
  • For the SIN validation (source reference), if the referenceIndex is not found on SIMS, assume the record is from SFAS and do not log as an error.
  • For income verifications, the records should already be skipped. Execute a manual test to ensure that a file with records that do not contain the VERIFICATION_ID in the free project area is skipped. Consider creating an E2E to execute the test.
  • Demo for both cases with a sample file.

@bidyashish bidyashish self-assigned this Oct 24, 2024
@bidyashish bidyashish marked this pull request as draft October 24, 2024 21:24
@bidyashish bidyashish changed the title add test sample files #3745 - Modify process that reads SIN & CRA verification response files Oct 25, 2024
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 83.81% ( 1170 / 1396 )
Methods: 83.94% ( 115 / 137 )
Lines: 84.74% ( 994 / 1173 )
Branches: 70.93% ( 61 / 86 )

Copy link

sonarcloud bot commented Oct 26, 2024

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.52% ( 3670 / 16295 )
Methods: 10.15% ( 206 / 2029 )
Lines: 25.9% ( 3186 / 12301 )
Branches: 14.15% ( 278 / 1965 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.01% ( 5571 / 8439 )
Methods: 63.3% ( 683 / 1079 )
Lines: 70.12% ( 4401 / 6276 )
Branches: 44.93% ( 487 / 1084 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant